Improve backporting prompt#509
Conversation
Be stricter about NOT backporting changelogs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the backport skill documentation and agent prompts to enhance build error tracking and refine file filtering logic. Key changes include the introduction of a process for archiving build logs and documenting fix attempts in a dedicated fix-attempts.md file to prevent redundant troubleshooting strategies. Additionally, the instructions were updated to mandate dropping all changes to non-core files (such as CI workflows, gitignore, and changelogs) regardless of whether they conflict. A review comment identifies a potential indexing inconsistency between the documentation and the implementation regarding the incremental_fix_attempts counter, which could lead to incorrect log archiving behavior.
| 6. If the fix **fails** → update `build_error` with the new error, go back to Step 5a. | ||
| 3. Archive build logs and record the error: | ||
| a. Create `<local_clone>-upstream/build-logs/` directory if it doesn't exist. | ||
| b. If `incremental_fix_attempts > 1`, move all `.log` and `.log.gz` files from `<local_clone>` to `<local_clone>-upstream/build-logs/attempt-<previous_attempt>/`. |
There was a problem hiding this comment.
The instruction If incremental_fix_attempts > 1 appears to use 1-based indexing, whereas the code in ymir/agents/backport_agent.py uses 0-based indexing for state.incremental_fix_attempts. This discrepancy may lead to confusion or incorrect behavior. Please ensure the documentation and code are consistent.
3 participants
Be stricter about NOT backporting changelogs
TODO:
packit/packit.dev.Fixes
Related to
Merge before/after
RELEASE NOTES BEGIN
Packit now supports automatic ordering of ☕ after all checks pass.
RELEASE NOTES END